]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: host: ohci-tmio: add IRQ check
authorSergey Shtylyov <s.shtylyov@omp.ru>
Fri, 13 Aug 2021 20:30:18 +0000 (23:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:41:21 +0000 (11:41 +0200)
commit77977cfd6b9b9b5e28bb3fda6f6d66c439b6eee7
treee224dfacd5cb1605026d49ad7955a6abab12e8fc
parentdf5db051713fc377363457f83e4f37d36c0b7783
usb: host: ohci-tmio: add IRQ check

[ Upstream commit 4ac5132e8a4300637a2da8f5d6bc7650db735b8a ]

The driver neglects to check the  result of platform_get_irq()'s call and
blithely passes the negative error codes to usb_add_hcd() (which takes
*unsigned* IRQ #), causing request_irq() that it calls to fail with
-EINVAL, overriding an original error code. Stop calling usb_add_hcd()
with the invalid IRQ #s.

Fixes: 78c73414f4f6 ("USB: ohci: add support for tmio-ohci cell")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/402e1a45-a0a4-0e08-566a-7ca1331506b1@omp.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ohci-tmio.c