]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tcp: sack option handling improvements
authorIlpo Järvinen <ij@kernel.org>
Tue, 16 Sep 2025 08:24:29 +0000 (10:24 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 18 Sep 2025 06:47:52 +0000 (08:47 +0200)
commit77a4fdf43c5ec81a431770511505d371c8822837
treee8b2e25885a8a9ae9aaf217f1d8e52fb43d85669
parenta92543d597621736b8e40fd1a2b50a93bd9840f7
tcp: sack option handling improvements

1) Don't early return when sack doesn't fit. AccECN code will be
   placed after this fragment so no early returns please.

2) Make sure opts->num_sack_blocks is not left undefined. E.g.,
   tcp_current_mss() does not memset its opts struct to zero.
   AccECN code checks if SACK option is present and may even
   alter it to make room for AccECN option when many SACK blocks
   are present. Thus, num_sack_blocks needs to be always valid.

Signed-off-by: Ilpo Järvinen <ij@kernel.org>
Signed-off-by: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250916082434.100722-6-chia-yu.chang@nokia-bell-labs.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/tcp_output.c