]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Use AsyncAdaptedQueuePool in aiosqlite
authorChristophe Bornet <cbornet@hotmail.com>
Fri, 31 Jan 2025 12:42:59 +0000 (07:42 -0500)
committerFederico Caselli <cfederico87@gmail.com>
Sat, 1 Feb 2025 20:51:17 +0000 (21:51 +0100)
commit78445beeb5484f264adecfca5feb0c712929254a
tree2e7981f08bd1b17c0aebd8a56a2c2c1917cfc4fb
parentbaa26f12f8a9fbe397a2ee6aef32305474edd8a7
Use AsyncAdaptedQueuePool in aiosqlite

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
Change default pool in `aiosqlite` from `NullPool` to `AsyncAdaptedQueuePool`.
This ensures consistency with pysqlite and least surprise when migrating from sync to async.
See discussion in https://github.com/sqlalchemy/sqlalchemy/discussions/12285
Non regression tested by existing tests.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed
- [x] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #12291
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/12291
Pull-request-sha: 5a0872b8d431a6937eaf05fb132578aed5723b6a

Change-Id: I96b4d0b5154b34cd26d3ad89774229b0f5d8686f
(cherry picked from commit 11bac714a2e83f6f903b1faf36d744854635da66)
doc/build/changelog/unreleased_20/12285.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/sqlite/aiosqlite.py