]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 25 Sep 2019 10:56:04 +0000 (13:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:32 +0000 (10:24 +0100)
commit784bf707470847502f1a4faefed1b6f344b1c329
treea4b3dc3afca0c8aa605fe80072ec51f6345bfd02
parent3f32f2547215d0749e2a28b0c71e15f11a850ecf
net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()

[ Upstream commit 25a584955f020d6ec499c513923fb220f3112d2b ]

The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as unsigned so the error handling will never be
triggered.

Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bcmsysport.c