]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: codecs: wcd938x-sdw: Correct Soundwire ports mask
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 26 Jul 2024 14:10:42 +0000 (16:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:20 +0000 (15:34 +0200)
commit784d7c42ed65053a1cfaa48317228f5754ab7461
tree2f9820f1da5e946b522006d48e1a6ffdc714b901
parent819964b42b8b4009ccbae504515f2202b4f6dbb0
ASoC: codecs: wcd938x-sdw: Correct Soundwire ports mask

[ Upstream commit 3f6fb03dae9c7dfba7670858d29e03c8faaa89fe ]

Device has up to WCD938X_MAX_SWR_PORTS number of ports and the array
assigned to prop.src_dpn_prop and prop.sink_dpn_prop has
0..WCD938X_MAX_SWR_PORTS-1 elements.  On the other hand, GENMASK(high,
low) creates an inclusive mask between <high, low>, so we need the mask
from 0 up to WCD938X_MAX_SWR_PORTS-1.

Theoretically, too wide mask could cause an out of bounds read in
sdw_get_slave_dpn_prop() in stream.c, however only in the case of buggy
driver, e.g. adding incorrect number of ports via
sdw_stream_add_slave().

Fixes: 16572522aece ("ASoC: codecs: wcd938x-sdw: add SoundWire driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240726-asoc-wcd-wsa-swr-ports-genmask-v1-2-d4d7a8b56f05@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wcd938x-sdw.c