]> git.ipfire.org Git - thirdparty/linux.git/commit
ethtool: rss: fix hkey leak when indir_size is 0
authorJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 23:06:46 +0000 (16:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:17:57 +0000 (08:17 -0700)
commit78ccf1a70c6378e1f5073a8c2209b5129067b925
tree8b333342a3ad02b84dfe789b11d95ab6a7507289
parent266297692f97008ca48bc311775c087c59bd7fe3
ethtool: rss: fix hkey leak when indir_size is 0

rss_get_data_alloc() allocates a single buffer that backs both the
indirection table and the hash key, but only assigned data->indir_table
when indir_size was nonzero. The expectation was that no driver
implements RSS without supporting indirection table but apparently
enic does just that (it's the only such in-tree driver).
enic has get_rxfh_key_size but no get_rxfh_indir_size.
data->indir_table stays as NULL, hkey gets set but rss_get_data_free()
kfree(data->indir_table) is a nop and the allocation leaks.

Always store the allocation base in data->indir_table so the free path
is unambiguous. No caller treats indir_table as a sentinel; everything
keys off indir_size.

Fixes: 7112a04664bf ("ethtool: add netlink based get rss support")
Link: https://patch.msgid.link/20260522230647.1705600-6-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/rss.c