]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amdgpu/sdma4: replace BUG_ON with WARN_ON in fence emission
authorJohn B. Moore <jbmoore61@gmail.com>
Mon, 27 Apr 2026 21:06:28 +0000 (16:06 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 5 May 2026 14:16:09 +0000 (10:16 -0400)
commit78d2e624fa073c14970aa097adcf3ea31c157a66
tree860d1a95bfa33fc4befc2ecfac7c8a58fd03f558
parent17223816498f7b117d138d18eb0eba63604dc74e
drm/amdgpu/sdma4: replace BUG_ON with WARN_ON in fence emission

sdma_v4_0_ring_emit_fence() contains two BUG_ON(addr & 0x3) assertions
that verify fence writeback addresses are dword-aligned.  These
assertions can be reached from unprivileged userspace via crafted
DRM_IOCTL_AMDGPU_CS submissions, causing a fatal kernel panic in a
scheduler worker thread.

Replace both BUG_ON() calls with WARN_ON() to log the condition without
crashing the kernel.  A misaligned fence address at this point indicates
a driver bug, but crashing the kernel is never the correct response when
the assertion is reachable from userspace.

The CS IOCTL path is the correct place to filter invalid submissions;
the ring emission callback is too late to do anything about it.

Fixes: 2130f89ced2c ("drm/amdgpu: add SDMA v4.0 implementation (v2)")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: John B. Moore <jbmoore61@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit b90250bd933afd1ba94d86d6b13821997b22b18e)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c