]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu_firmware: Extend qemuFirmwareGetSupported to return FW paths
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 5 Aug 2019 12:56:32 +0000 (14:56 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 12 Sep 2019 10:31:39 +0000 (12:31 +0200)
commit78f8769a84ad2a799cd445f7739b5a0e285e0c8c
tree03a8331aff9ae4daa56c990c494d783a6f01835b
parentbc7fe2f56ddd0a50b1e40086c586f3a395b65099
qemu_firmware: Extend qemuFirmwareGetSupported to return FW paths

The qemuFirmwareGetSupported() function is called from qemu
driver to generate domain capabilities XML based on FW descriptor
files. However, the function currently reports only some features
from domcapabilities XML and not actual FW image paths. The paths
reported in the domcapabilities XML are still from pre-FW
descriptor era and therefore the XML might be a bit confusing.
For instance, it may say that secure boot is supported but
secboot enabled FW is not in the listed FW image paths.

To resolve this problem, change qemuFirmwareGetSupported() so
that it also returns a list of FW images (we have the list
anyway). Luckily, we already have a structure to represent a FW
image - virFirmware.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1733940

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
src/qemu/qemu_capabilities.c
src/qemu/qemu_firmware.c
src/qemu/qemu_firmware.h
tests/qemufirmwaretest.c