]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: allow PMU feature to be enabled for ppc64 guests
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Tue, 24 Mar 2020 17:33:24 +0000 (14:33 -0300)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 25 Mar 2020 13:55:23 +0000 (14:55 +0100)
commit79736aaa98190fbfab4d02dfc05a8b2faa6ec731
tree0376c446a66f53367ccbc52c21da855afa1994b8
parentf1ea75233b6f460ed13d6f2dbb849c91e85e5f48
qemu: allow PMU feature to be enabled for ppc64 guests

The PMU feature is enabled by default in ppc64 guests and can't
be disabled via Libvirt or QEMU [1]. The current PMU feature
implementation does not allow PMU to enabled or disabled in the
ppc64 guest. Declaring the PMU feature will make the 'pmu'
property to be passed on to QEMU, but this property isn't
available for ppc64:

qemu-kvm: can't apply global host-powerpc64-cpu.pmu=on: Property '.pmu' not found

A similar error is thrown when trying to disable the PMU.

This patch standardizes the PMU handling for ppc64 guests by:

- throwing an error if the user attempts to set the feature to
'off', given that this feature can't be turned off at all;

- allowing the feature to be declared as 'on' in the domain XML.
This is done by skipping ppc64 guests when creating the command
line for this feature.

[1] https://www.redhat.com/archives/libvir-list/2020-March/msg00874.html

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_domain.c