]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
unix: correctly track in-flight fds in sending process user_struct
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Wed, 3 Feb 2016 01:11:03 +0000 (02:11 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 4 Mar 2016 15:25:48 +0000 (10:25 -0500)
commit797c009c98dbb21127a2549d1106ed19d18661cf
tree3b3b0e2bd49506b51d5580c106cc68a1ff7c93af
parent6c92a8f0502d3e9a9036473408f7f67b58f22ea9
unix: correctly track in-flight fds in sending process user_struct

[ Upstream commit 415e3d3e90ce9e18727e8843ae343eda5a58fad6 ]

The commit referenced in the Fixes tag incorrectly accounted the number
of in-flight fds over a unix domain socket to the original opener
of the file-descriptor. This allows another process to arbitrary
deplete the original file-openers resource limit for the maximum of
open files. Instead the sending processes and its struct cred should
be credited.

To do so, we add a reference counted struct user_struct pointer to the
scm_fp_list and use it to account for the number of inflight unix fds.

Fixes: 712f4aad406bb1 ("unix: properly account for FDs passed over unix sockets")
Reported-by: David Herrmann <dh.herrmann@gmail.com>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
include/net/af_unix.h
include/net/scm.h
net/core/scm.c
net/unix/af_unix.c
net/unix/garbage.c