]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cxl: Allow release of contexts which have been OPENED but not STARTED
authorAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Tue, 18 Aug 2015 23:27:18 +0000 (09:27 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Sep 2015 17:33:18 +0000 (19:33 +0200)
commit79a5262499d5c19318b59bf42fc5e2d126cde3c7
tree926fc84cc84a2eb16b51a576b9bd50b882129f0c
parentecf973ad507196f407481a44f355e49a208d3fbf
cxl: Allow release of contexts which have been OPENED but not STARTED

commit 7c26b9cf5347c24272152438cdd9675183804425 upstream.

If we open a context but do not start it (either because we do not attempt
to start it, or because it fails to start for some reason), we are left
with a context in state OPENED. Previously, cxl_release_context() only
allowed releasing contexts in state CLOSED, so attempting to release an
OPENED context would fail.

In particular, this bug causes available contexts to run out after some EEH
failures, where drivers attempt to release contexts that have failed to
start.

Allow releasing contexts in any state with a value lower than STARTED, i.e.
OPENED or CLOSED (we can't release a STARTED context as it's currently
using the hardware, and we assume that contexts in any new states which may
be added in future with a value higher than STARTED are also unsafe to
release).

Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/cxl/api.c