]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tty/serial: at91: fix error handling in atmel_serial_probe()
authorCyrille Pitchen <cyrille.pitchen@atmel.com>
Tue, 9 Dec 2014 13:31:34 +0000 (14:31 +0100)
committerJiri Slaby <jslaby@suse.cz>
Sun, 1 Mar 2015 22:34:20 +0000 (23:34 +0100)
commit79abbf657e16a14ab146498001f94398c5a5de32
treefc4c988fb07751548fb624908d1c0447bb57a81c
parent09179f19a3a7b87482925384ef1c21af546b8910
tty/serial: at91: fix error handling in atmel_serial_probe()

commit 6fbb9bdf0f3fbe23aeff806489791aa876adaffb upstream.

-EDEFER error wasn't handle properly by atmel_serial_probe().
As an example, when atmel_serial_probe() is called for the first time, we pass
the test_and_set_bit() test to check whether the port has already been
initalized. Then we call atmel_init_port(), which may return -EDEFER, possibly
returned before by clk_get(). Consequently atmel_serial_probe() used to return
this error code WITHOUT clearing the port bit in the "atmel_ports_in_use" mask.
When atmel_serial_probe() was called for the second time, it used to fail on
the test_and_set_bit() function then returning -EBUSY.

When atmel_serial_probe() fails, this patch make it clear the port bit in the
"atmel_ports_in_use" mask, if needed, before returning the error code.

Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/tty/serial/atmel_serial.c