]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm/slab: make __free(kfree) accept error pointers
authorDan Carpenter <dan.carpenter@linaro.org>
Sun, 28 Apr 2024 14:26:44 +0000 (17:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 10:15:01 +0000 (12:15 +0200)
commit79cbe0be6c0317b215ddd8bd3e32f0afdac48543
tree8defb167ecc11807fd59567487d2b131d8e3b656
parentf3956791cf526540addd3295e4c1e0f0442486cc
mm/slab: make __free(kfree) accept error pointers

commit cd7eb8f83fcf258f71e293f7fc52a70be8ed0128 upstream.

Currently, if an automatically freed allocation is an error pointer that
will lead to a crash.  An example of this is in wm831x_gpio_dbg_show().

   171 char *label __free(kfree) = gpiochip_dup_line_label(chip, i);
   172 if (IS_ERR(label)) {
   173 dev_err(wm831x->dev, "Failed to duplicate label\n");
   174 continue;
   175  }

The auto clean up function should check for error pointers as well,
otherwise we're going to keep hitting issues like this.

Fixes: 54da6a092431 ("locking: Introduce __cleanup() based infrastructure")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/slab.h