]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ionic: fix up issues with handling EAGAIN on FW cmds
authorShannon Nelson <snelson@pensando.io>
Wed, 24 Aug 2022 16:50:50 +0000 (09:50 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Aug 2022 15:18:11 +0000 (17:18 +0200)
commit79e77fb1565d00c76692166cfe614b38ed6b6e0f
treeb64317b3a24a1bae3fc580fdb2c9768853761f2b
parent94d71d99e5dd5885d1a0bef8de5eabe21e7750f0
ionic: fix up issues with handling EAGAIN on FW cmds

[ Upstream commit 0fc4dd452d6c14828eed6369155c75c0ac15bab3 ]

In looping on FW update tests we occasionally see the
FW_ACTIVATE_STATUS command fail while it is in its EAGAIN loop
waiting for the FW activate step to finsh inside the FW.  The
firmware is complaining that the done bit is set when a new
dev_cmd is going to be processed.

Doing a clean on the cmd registers and doorbell before exiting
the wait-for-done and cleaning the done bit before the sleep
prevents this from occurring.

Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_main.c