]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: Do not use stack memory with scatterlist for GMAC
authorJouni Malinen <j@w1.fi>
Mon, 27 May 2019 22:46:43 +0000 (01:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jun 2019 03:34:56 +0000 (11:34 +0800)
commit7a6638862b1dc1b15b0069a70779f9c924697b7d
treec3c8e3b08317f0ea81e54d4d4e39e22abcfad4e7
parent34e22e35d487eb5024d5bf2ad046e99fbd35f55c
mac80211: Do not use stack memory with scatterlist for GMAC

commit a71fd9dac23613d96ba3c05619a8ef4fd6cdf9b9 upstream.

ieee80211_aes_gmac() uses the mic argument directly in sg_set_buf() and
that does not allow use of stack memory (e.g., BUG_ON() is hit in
sg_set_buf() with CONFIG_DEBUG_SG). BIP GMAC TX side is fine for this
since it can use the skb data buffer, but the RX side was using a stack
variable for deriving the local MIC value to compare against the
received one.

Fix this by allocating heap memory for the mic buffer.

This was found with hwsim test case ap_cipher_bip_gmac_128 hitting that
BUG_ON() and kernel panic.

Cc: stable@vger.kernel.org
Signed-off-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mac80211/wpa.c