]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sctp: avoid BUG_ON on sctp_wait_for_sndbuf
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Mon, 6 Feb 2017 20:10:31 +0000 (18:10 -0200)
committerJiri Slaby <jslaby@suse.cz>
Wed, 1 Mar 2017 08:59:48 +0000 (09:59 +0100)
commit7a814bf5fc8b6738af64bc05d824a22d269962c6
tree002e2573aec7630a30a81cb094146c7da44f0296
parente1413a0ea8c90c4e5c63ebdcbbff620658b91182
sctp: avoid BUG_ON on sctp_wait_for_sndbuf

[ Upstream commit 2dcab598484185dea7ec22219c76dcdd59e3cb90 ]

Alexander Popov reported that an application may trigger a BUG_ON in
sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is
waiting on it to queue more data and meanwhile another thread peels off
the association being used by the first thread.

This patch replaces the BUG_ON call with a proper error handling. It
will return -EPIPE to the original sendmsg call, similarly to what would
have been done if the association wasn't found in the first place.

Acked-by: Alexander Popov <alex.popov@linux.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/sctp/socket.c