]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kernel/sysctl.c: add missing range check in do_proc_dointvec_minmax_conv
authorZev Weiss <zev@bewilderbeest.net>
Tue, 12 Mar 2019 06:28:02 +0000 (23:28 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 9 Jul 2019 21:04:16 +0000 (22:04 +0100)
commit7a8c67f3ff34e9df1e8a13e3f6b924dcf1543c4c
tree919581b0ff8859cfe2bb0071268c61cf164fcbaf
parent415f08eb363a0204fb185743469f500e120c6618
kernel/sysctl.c: add missing range check in do_proc_dointvec_minmax_conv

commit 8cf7630b29701d364f8df4a50e4f1f5e752b2778 upstream.

This bug has apparently existed since the introduction of this function
in the pre-git era (4500e91754d3 in Thomas Gleixner's history.git,
"[NET]: Add proc_dointvec_userhz_jiffies, use it for proper handling of
neighbour sysctls.").

As a minimal fix we can simply duplicate the corresponding check in
do_proc_dointvec_conv().

Link: http://lkml.kernel.org/r/20190207123426.9202-3-zev@bewilderbeest.net
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: Iurii Zaikin <yzaikin@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/sysctl.c