]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
firmware: cs_dsp: Remove __free() from cs_dsp_debugfs_string_read()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 2 Dec 2025 11:34:25 +0000 (11:34 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:37:31 +0000 (19:37 +0900)
commit7a9fa7fda93b7b3ae515f40f67bbf8e1d16337e8
treea1d75981f2a18ba756bdd29a011904c8c463092e
parent69927c13d5c5444f5f774e891fa5970ae1bac4b5
firmware: cs_dsp: Remove __free() from cs_dsp_debugfs_string_read()

Don't use __free(kfree) in cs_dsp_debugfs_string_read. Instead use
normal kfree() to cleanup.

The use of __free() can create new cleanup bugs that are difficult to spot
because the defective code is idiomatically correct regular C. This
function used the suspect declaration __free(kfree) = NULL;.

The __free(kfree) didn't really do anything here. The function can be
rearranged to avoid any need to return or goto within the code.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 3045e29d248b ("firmware: cs_dsp: Append \n to debugfs string during read")
Link: https://patch.msgid.link/20251202113425.413700-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/firmware/cirrus/cs_dsp.c