]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ip_forward: Drop frames with attached skb->sk
authorSebastian Pöhn <sebastian.poehn@gmail.com>
Mon, 20 Apr 2015 07:19:20 +0000 (09:19 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 11 May 2015 11:07:55 +0000 (07:07 -0400)
commit7aca2472093e9353793faeede03c94d00ce42fb1
treee00b6ccbadebb55fabb8be21f7367ea4cd3c82f0
parente13f6f2b39c4d91371c0ede88b136f364a6ffd6d
ip_forward: Drop frames with attached skb->sk

[ Upstream commit 2ab957492d13bb819400ac29ae55911d50a82a13 ]

Initial discussion was:
[FYI] xfrm: Don't lookup sk_policy for timewait sockets

Forwarded frames should not have a socket attached. Especially
tw sockets will lead to panics later-on in the stack.

This was observed with TPROXY assigning a tw socket and broken
policy routing (misconfigured). As a result frame enters
forwarding path instead of input. We cannot solve this in
TPROXY as it cannot know that policy routing is broken.

v2:
Remove useless comment

Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/ipv4/ip_forward.c