]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
gpu: nova-core: gsp: move appropriate code into pin initializer
authorDanilo Krummrich <dakr@kernel.org>
Thu, 18 Dec 2025 15:50:51 +0000 (16:50 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 29 Dec 2025 16:54:32 +0000 (17:54 +0100)
commit7acc70476f14661149774ab88d3fe23d83ba4249
treed2a87efaa961de1a322cebaf348c7e6800271091
parent032a6772d663a26005f4c17be992a716457f095b
gpu: nova-core: gsp: move appropriate code into pin initializer

Relocate the code that technically fits in the pin initializer into the
initializer itself.

While, thanks to pin_init_scope(), it is also possible to keep it as is,
moving appropriate code into the initializer has the advantage that it
structures the dependencies of fields naturally.

For instance, intermediate data that is only needed for a single field
goes into the initializer block of this field, making it obvious that it
is not needed by anything else.

On the other hand, intermediate data that is needed for multiple fields
to initialize remains above the initializer, naturally indicating that
it is needed my multiple fields.

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Link: https://patch.msgid.link/20251218155239.25243-5-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/nova-core/gsp.rs