]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-42388: Fix subprocess.check_output input=None when text=True (GH-23467)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 25 Dec 2020 05:18:37 +0000 (21:18 -0800)
committerGitHub <noreply@github.com>
Fri, 25 Dec 2020 05:18:37 +0000 (21:18 -0800)
commit7acfe4125725e86c982300cf10c0ab791a0783f4
tree2c9445799a0c06d3878802a0d230a34508890bac
parent5a6b5d8c392ca7028e7c034710a89492cd704778
bpo-42388: Fix subprocess.check_output input=None when text=True (GH-23467)

When the modern text= spelling of the universal_newlines= parameter was added
for Python 3.7, check_output's special case around input=None was overlooked.
So it behaved differently with universal_newlines=True vs text=True.  This
reconciles the behavior to be consistent and adds a test to guarantee it.

Also clarifies the existing check_output documentation.

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
(cherry picked from commit 64abf373444944a240274a9b6d66d1cb01ecfcdd)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Doc/library/subprocess.rst
Lib/subprocess.py
Lib/test/test_subprocess.py
Misc/NEWS.d/next/Library/2020-11-22-11-22-28.bpo-42388.LMgM6B.rst [new file with mode: 0644]