]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gfs2: Fix slab-use-after-free in gfs2_qd_dealloc
authorJuntong Deng <juntong.deng@outlook.com>
Sun, 29 Oct 2023 21:10:06 +0000 (05:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:32:00 +0000 (09:32 +0200)
commit7ad4e0a4f61c57c3ca291ee010a9d677d0199fba
treedfff8878ea0249501609ecdf1f20dd6f0f7cc485
parent447434eaaf3f057a59557ae2a1f94db09e0f296a
gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

commit bdcb8aa434c6d36b5c215d02a9ef07551be25a37 upstream.

In gfs2_put_super(), whether withdrawn or not, the quota should
be cleaned up by gfs2_quota_cleanup().

Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu
callback) has run for all gfs2_quota_data objects, resulting in
use-after-free.

Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called
by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling
gfs2_make_fs_ro(), there is no need to call them again.

Reported-by: syzbot+29c47e9e51895928698c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
fs/gfs2/super.c