]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
md/raid5: fix possible null-pointer dereferences in raid5_store_group_thread_cnt()
authorTuo Li <islituo@gmail.com>
Thu, 25 Dec 2025 13:03:26 +0000 (21:03 +0800)
committerYu Kuai <yukuai@fnnas.com>
Sat, 27 Dec 2025 01:51:35 +0000 (09:51 +0800)
commit7ad6ef91d8745d04aff9cce7bdbc6320d8e05fe9
tree4385e80d9a657b5301b20a62822922f8254fe7a6
parent00f6c1b4d15d35fadb7f34768a1831c81aaa8936
md/raid5: fix possible null-pointer dereferences in raid5_store_group_thread_cnt()

The variable mddev->private is first assigned to conf and then checked:

  conf = mddev->private;
  if (!conf) ...

If conf is NULL, then mddev->private is also NULL. In this case,
null-pointer dereferences can occur when calling raid5_quiesce():

  raid5_quiesce(mddev, true);
  raid5_quiesce(mddev, false);

since mddev->private is assigned to conf again in raid5_quiesce(), and conf
is dereferenced in several places, for example:

  conf->quiesce = 0;
  wake_up(&conf->wait_for_quiescent);

To fix this issue, the function should unlock mddev and return before
invoking raid5_quiesce() when conf is NULL, following the existing pattern
in raid5_change_consistency_policy().

Fixes: fa1944bbe622 ("md/raid5: Wait sync io to finish before changing group cnt")
Signed-off-by: Tuo Li <islituo@gmail.com>
Reviewed-by: Xiao Ni <xni@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/linux-raid/20251225130326.67780-1-islituo@gmail.com
Signed-off-by: Yu Kuai <yukuai@fnnas.com>
drivers/md/raid5.c