]> git.ipfire.org Git - thirdparty/patchwork.git/commit
cron: fix deletion of unactivated accounts
authorDaniel Axtens <dja@axtens.net>
Tue, 11 Jul 2017 06:30:48 +0000 (16:30 +1000)
committerStephen Finucane <stephen@that.guru>
Wed, 12 Jul 2017 09:33:38 +0000 (10:33 +0100)
commit7ada8ccd1a89c274a6db68104f78f5d4aff4e943
tree39ee8eb24c48cbd5bdbd59ba73623edadd02319e
parentae6cd3bcc76c34b9f449319a7de8859ba4705ca9
cron: fix deletion of unactivated accounts

There is a test in expire_notifications() that tries to check if
the user's last login matches the date joined. (I think the login
date is not set until a post-activation login.) This does not work:
on patchwork.ozlabs.org there are 10k users that have never been
deleted.

Drop the date test: it should be sufficient that a user is not
active and their confirmation is not pending.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Stephen Finucane <stephen@that.guru>
patchwork/notifications.py