]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ARM: OMAP2+: Fix omap off idle power consumption creeping up
authorTony Lindgren <tony@atomide.com>
Mon, 4 May 2015 15:54:41 +0000 (08:54 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 9 Jun 2015 17:43:30 +0000 (13:43 -0400)
commit7b022b8ad207d2d0ce8aa8a16d22a424a417f28d
tree0e405967ce5f2484d945f0c3bd8a8d8be130946f
parent0f0e4765c9f488fe1af9973be323cb2dd2326059
ARM: OMAP2+: Fix omap off idle power consumption creeping up

[ Upstream commit 102bcb6ed2d1c3ffcc7269afc957c2df11942085 ]

If we use a combination of VMODE and I2C4 for retention modes,
eventually the off idle power consumption will creep up by about
23mW, even during off mode with I2C4 always staying enabled.

Turns out this is because of erratum i531 "Extra Power Consumed
When Repeated Start Operation Mode Is Enabled on I2C Interface
Dedicated for Smart Reflex (I2C4)" as pointed out by Nishanth
Menon <nm@ti.com>.

Let's fix the issue by adding i2c_cfg_clear_mask for the bits
to clear when initializing the I2C4 adapter so we can clear
SREN bit that drives the I2C4 lines low otherwise when there
is no traffic.

Fixes: 3b8c4ebb7630 ("ARM: OMAP3: Fix idle mode signaling for
Cc: stable@vger.kernel.org # v3.16+
sys_clkreq and sys_off_mode")
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
arch/arm/mach-omap2/prm-regbits-34xx.h
arch/arm/mach-omap2/prm-regbits-44xx.h
arch/arm/mach-omap2/vc.c
arch/arm/mach-omap2/vc.h
arch/arm/mach-omap2/vc3xxx_data.c
arch/arm/mach-omap2/vc44xx_data.c