]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
authorTakashi Iwai <tiwai@suse.de>
Tue, 29 Nov 2016 21:28:40 +0000 (22:28 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:39:46 +0000 (17:39 +0100)
commit7b0713fb9aa966f2c70679338ec08582c4e4d1cd
treee42b332243341a24d57140c09aedf972aa97897b
parentaece02071e5848b3837283e565fceb43bc3f5c70
ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()

commit 4763601a56f155ddf94ef35fc2c41504a2de15f5 upstream.

The function returns -EINVAL even if it builds the stream properly.
The bogus error code sneaked in during the code refactoring, but it
wasn't noticed until now since the returned error code itself is
ignored in anyway.  Kill it here, but there is no behavior change by
this patch, obviously.

Fixes: e5779998bf8b ('ALSA: usb-audio: refactor code')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
sound/usb/card.c