]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
namespace: update event counter when umounting a deleted dentry
authorAndrey Ulanov <andreyu@google.com>
Fri, 15 Apr 2016 21:24:41 +0000 (14:24 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Aug 2016 10:54:47 +0000 (12:54 +0200)
commit7b1789f9d96d273729dde7e66cb2d80153d53788
treeb6fa25b70f6d8caa92253f74605572c69fd3064b
parenta0292a0f78ad08db0a9b8eaba19a25c2b4fa75d8
namespace: update event counter when umounting a deleted dentry

commit e06b933e6ded42384164d28a2060b7f89243b895 upstream.

- m_start() in fs/namespace.c expects that ns->event is incremented each
  time a mount added or removed from ns->list.
- umount_tree() removes items from the list but does not increment event
  counter, expecting that it's done before the function is called.
- There are some codepaths that call umount_tree() without updating
  "event" counter. e.g. from __detach_mounts().
- When this happens m_start may reuse a cached mount structure that no
  longer belongs to ns->list (i.e. use after free which usually leads
  to infinite loop).

This change fixes the above problem by incrementing global event counter
before invoking umount_tree().

Change-Id: I622c8e84dcb9fb63542372c5dbf0178ee86bb589
Signed-off-by: Andrey Ulanov <andreyu@google.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/namespace.c