]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: nitrox - avoid double free on error path in nitrox_sriov_init()
authorNatalia Petrova <n.petrova@fintech.ru>
Wed, 28 Sep 2022 10:25:05 +0000 (13:25 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:26:16 +0000 (13:26 +0100)
commit7b66c11c5f69662484175a95cdf0ee5c192567bf
treef546410bcba291439eda79adc8cf2b027686fc0a
parentfc5be8489caf39d30af1f2e85e2ed73a4a02b879
crypto: nitrox - avoid double free on error path in nitrox_sriov_init()

[ Upstream commit 094528b6a5a755b1195a01e10b13597d67d1a0e6 ]

If alloc_workqueue() fails in nitrox_mbox_init() it deallocates
ndev->iov.vfdev and returns error code, but then nitrox_sriov_init()
calls nitrox_sriov_cleanup() where ndev->iov.vfdev is deallocated
again.

Fix this by nulling ndev->iov.vfdev after the first deallocation.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 9e5de3e06e54 ("crypto: cavium/nitrox - Add mailbox...")
Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/cavium/nitrox/nitrox_mbx.c