]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
cxl: Fix premature commit_end increment on decoder commit failure
authorYuxiong Wang <yuxiong.wang@linux.alibaba.com>
Thu, 29 Jan 2026 06:45:52 +0000 (14:45 +0800)
committerDave Jiang <dave.jiang@intel.com>
Thu, 29 Jan 2026 18:00:35 +0000 (11:00 -0700)
commit7b6f9d9b1ea05c9c22570126547c780e8c6c3f62
treed17e66ef31b6dc0b39fa71f537ea71f38587098c
parent064c098790944fa44f6aa704eb55a5c3ed65a2fa
cxl: Fix premature commit_end increment on decoder commit failure

In cxl_decoder_commit(), commit_end is incremented before verifying
whether the commit succeeded, and the CXL_DECODER_F_ENABLE bit in
cxld->flags is only set after a successful commit. As a result, if the
commit fails, commit_end has been incremented and cxld->reset() has no
effect since the flag is not set, so commit_end remains incorrectly
incremented. The inconsistency between commit_end and CXL_DECODER_F_ENABLE
causes failure during subsequent either commit or reset operations.

Fix this by incrementing commit_end only after confirming the commit
succeeded. Also, remove the ineffective cxld->reset() call. According to
CXL Spec r4.0 8.2.4.20.12 Committing Decoder Programming, since
cxld_await_commit() has cleared the decoder commit bit on failure, no
additional reset is required.

[dj: Fixed commit log 80 char wrapping. ]
[dj: Fix "Fixes" tag to correct hash length. ]
[dj: Change spec to r4.0. ]

Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware")
Signed-off-by: Yuxiong Wang <yuxiong.wang@linux.alibaba.com>
Acked-by: Huang Ying <ying.huang@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Link: https://patch.msgid.link/20260129064552.31180-1-yuxiong.wang@linux.alibaba.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/hdm.c