]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: sctp: fix passing wrong parameter header to param_type2af in sctp_process_param
authorSaran Maruti Ramanara <saran.neti@telus.com>
Thu, 29 Jan 2015 10:05:58 +0000 (11:05 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 10 Feb 2015 10:16:52 +0000 (11:16 +0100)
commit7b7685e37bc001fc53b96f7aaf5894eddf914ca4
treec8215b6ce4bf00de8aea01101622b8591205b31f
parent030892ea1af3f4ff26a9474690e75f211b9b592a
net: sctp: fix passing wrong parameter header to param_type2af in sctp_process_param

[ Upstream commit cfbf654efc6d78dc9812e030673b86f235bf677d ]

When making use of RFC5061, section 4.2.4. for setting the primary IP
address, we're passing a wrong parameter header to param_type2af(),
resulting always in NULL being returned.

At this point, param.p points to a sctp_addip_param struct, containing
a sctp_paramhdr (type = 0xc004, length = var), and crr_id as a correlation
id. Followed by that, as also presented in RFC5061 section 4.2.4., comes
the actual sctp_addr_param, which also contains a sctp_paramhdr, but
this time with the correct type SCTP_PARAM_IPV{4,6}_ADDRESS that
param_type2af() can make use of. Since we already hold a pointer to
addr_param from previous line, just reuse it for param_type2af().

Fixes: d6de3097592b ("[SCTP]: Add the handling of "Set Primary IP Address" parameter to INIT")
Signed-off-by: Saran Maruti Ramanara <saran.neti@telus.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/sctp/sm_make_chunk.c