]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: usb: dvd-usb: fix uninit-value bug in dibusb_read_eeprom_byte()
authorAnant Thazhemadam <anant.thazhemadam@gmail.com>
Mon, 7 Dec 2020 06:16:06 +0000 (07:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:58:37 +0000 (11:58 +0100)
commit7bf3eed751ee06112aa0dfcc92603509e2bc6722
tree80d5d5fd8d1cfebdd218e4591df384e7247360f2
parent12cf2b9b86661691226a7c229aa1e96a31849f83
media: usb: dvd-usb: fix uninit-value bug in dibusb_read_eeprom_byte()

[ Upstream commit 899a61a3305d49e8a712e9ab20d0db94bde5929f ]

In dibusb_read_eeprom_byte(), if dibusb_i2c_msg() fails, val gets
assigned an value that's not properly initialized.
Using kzalloc() in place of kmalloc() for the buffer fixes this issue,
as the val can now be set to 0 in the event dibusb_i2c_msg() fails.

Reported-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com
Tested-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/dvb-usb/dibusb-common.c