]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: greybus: codecs: Fix reference counter leak in error handling
authorZhang Qilong <zhangqilong3@huawei.com>
Mon, 9 Nov 2020 13:13:46 +0000 (21:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:53 +0000 (11:25 +0100)
commit7c54e646390e424e07df1a33f8d8b9dc4b721d8a
treec4f946a661c73a69093df7f9a05856fb9858c6e2
parent462850d0db0803ff192f7ea4a52c77c0907f78f6
staging: greybus: codecs: Fix reference counter leak in error handling

[ Upstream commit 3952659a6108f77a0d062d8e8487bdbdaf52a66c ]

gb_pm_runtime_get_sync has increased the usage counter of the device here.
Forgetting to call gb_pm_runtime_put_noidle will result in usage counter
leak in the error branch of (gbcodec_hw_params and gbcodec_prepare). We
fixed it by adding it.

Fixes: c388ae7696992 ("greybus: audio: Update pm runtime support in dai_ops callback")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201109131347.1725288-2-zhangqilong3@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/greybus/audio_codec.c