]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: fix init and cleanup of sco_conn.timeout_work
authorDesmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Fri, 3 Sep 2021 03:13:06 +0000 (23:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:00:47 +0000 (09:00 +0100)
commit7c761641df3eac99583cbde01b46f839b5a99428
treedf47fdf2c971bb67ae821203739d63dab5fd1714
parentfea63ccd928c01573306983346588b26cffb5572
Bluetooth: fix init and cleanup of sco_conn.timeout_work

commit 49d8a5606428ca0962d09050a5af81461ff90fbb upstream.

Before freeing struct sco_conn, all delayed timeout work should be
cancelled. Otherwise, sco_sock_timeout could potentially use the
sco_conn after it has been freed.

Additionally, sco_conn.timeout_work should be initialized when the
connection is allocated, not when the channel is added. This is
because an sco_conn can create channels with multiple sockets over its
lifetime, which happens if sockets are released but the connection
isn't deleted.

Fixes: ba316be1b6a0 ("Bluetooth: schedule SCO timeouts with delayed_work")
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
[OP: adjusted context for 4.14]
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/sco.c