]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ieee802154: adf7242: Fix some potential buffer overflow in adf7242_stats_show()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 21 Oct 2023 18:03:53 +0000 (20:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Nov 2023 08:35:27 +0000 (09:35 +0100)
commit7c799bc32232a4e55ef01b98fa62005352b572f1
tree5386caa2477a6793f2fc01c45887db23d13d9521
parent55b01c5a847e13949498780fd3060143c02ed1b8
net: ieee802154: adf7242: Fix some potential buffer overflow in adf7242_stats_show()

[ Upstream commit ca082f019d8fbb983f03080487946da714154bae ]

strncat() usage in adf7242_debugfs_init() is wrong.
The size given to strncat() is the maximum number of bytes that can be
written, excluding the trailing NULL.

Here, the size that is passed, DNAME_INLINE_LEN, does not take into account
the size of "adf7242-" that is already in the array.

In order to fix it, use snprintf() instead.

Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ieee802154/adf7242.c