]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: require reply from guest agent in qemuAgentGetInterfaces
authorJán Tomko <jtomko@redhat.com>
Fri, 4 Jan 2019 09:17:46 +0000 (10:17 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 10 Jan 2019 11:09:48 +0000 (12:09 +0100)
commit7cfd1fbb1332ae5df678b9f41a62156cb2e88c73
treedeae4afea2a458392b0d58dff5e3f885ffdbaeba
parentc39a0993dc509702f375b5ed55cbcbcdd6a9ca23
qemu: require reply from guest agent in qemuAgentGetInterfaces

Since its introduction in commit 0977b8aa071 (released in v1.2.14)
qemuAgentGetInterfaces calls qemuAgentCommand with needReply=false,
which allows qemuAgentCommand to return 0 even when it did not get
any reply from the agent.

Set needReply to true, since we dereference it right after.

This can be hit if libvirt is waiting for an event from the agent
(e.g. shutdown) and the agent cannot reply in time (e.g. due to
the guest being shut down), as reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=1663051

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_agent.c