]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: threads: fix soft-stop without multithreading support
authorAurelien DARRAGON <adarragon@haproxy.com>
Mon, 12 May 2025 09:57:39 +0000 (11:57 +0200)
committerAurelien DARRAGON <adarragon@haproxy.com>
Mon, 12 May 2025 12:18:39 +0000 (14:18 +0200)
commit7d057e56af86cdc98c5388986931c247dbafa5b3
treee1b59116d14698407fb26f71331f9373ddedda56
parent8b0d1a41136dede6b414b2432ecdcbfc821b37e0
BUG/MINOR: threads: fix soft-stop without multithreading support

When thread support is disabled ("USE_THREAD=" or "USE_THREAD=0" when
building), soft-stop doesn't work as haproxy never ends after stopping
the proxies.

This used to work fine in the past but suddenly stopped working with
ef422ced91 ("MEDIUM: thread: make stopping_threads per-group and add
stopping_tgroups") because the "break;" instruction under the stopping
condition is never executed when support for multithreading is disabled.

To fix the issue, let's add an "else" block to run the "break;"
instruction when USE_THREAD is not defined.

It should be backported up to 2.8
src/haproxy.c