]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
blk-rq-qos: Remove unlikely() hints from QoS checks
authorBreno Leitao <leitao@debian.org>
Tue, 6 Jan 2026 14:26:57 +0000 (06:26 -0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 7 Jan 2026 02:08:23 +0000 (19:08 -0700)
commit7d121d701d58a92f26decb10da1d04a88b74519d
tree86d91f926e43c056431c7809f86a1d611017decb
parent08e136ebd193eae7d5eff4c66d576c4a2dabdc3f
blk-rq-qos: Remove unlikely() hints from QoS checks

The unlikely() annotations on QUEUE_FLAG_QOS_ENABLED checks are
counterproductive. Writeback throttling (WBT) might be enabled by
default, mainly because CONFIG_BLK_WBT_MQ defaults to 'y'.

Branch profiling on Meta servers, which have WBT enabled, confirms 100%
misprediction rates on these checks.

Remove the unlikely() annotations to let the CPU's branch predictor
learn the actual behavior, potentially improving I/O path performance.

Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-rq-qos.h