]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: clean up our handling of refs == 0 in snapshot delete
authorJosef Bacik <josef@toxicpanda.com>
Tue, 7 May 2024 18:12:13 +0000 (14:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:11:37 +0000 (11:11 +0200)
commit7d1df13bf078ffebfedd361d714ff6cee1ff01b9
treeb5b94ece78856d4b3ccd22ba41ea4e43328676df
parente7469c65b3c54a52fe0c63016497f17f9fd6fa22
btrfs: clean up our handling of refs == 0 in snapshot delete

[ Upstream commit b8ccef048354074a548f108e51d0557d6adfd3a3 ]

In reada we BUG_ON(refs == 0), which could be unkind since we aren't
holding a lock on the extent leaf and thus could get a transient
incorrect answer.  In walk_down_proc we also BUG_ON(refs == 0), which
could happen if we have extent tree corruption.  Change that to return
-EUCLEAN.  In do_walk_down() we catch this case and handle it correctly,
however we return -EIO, which -EUCLEAN is a more appropriate error code.
Finally in walk_up_proc we have the same BUG_ON(refs == 0), so convert
that to proper error handling.  Also adjust the error message so we can
actually do something with the information.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/extent-tree.c