]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/mlx5e: Fix NULL pointer dereference in ioctl module EEPROM query
authorGal Pressman <gal@nvidia.com>
Thu, 25 Dec 2025 13:27:15 +0000 (15:27 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sun, 4 Jan 2026 18:38:50 +0000 (10:38 -0800)
commit7d36a4a8bf62dc508bc6bb4b59727aec25064ca5
tree6ce14bb5d47a3a23a7ad80c49bcba58a5bdd3a4e
parent6c75dc9de40ff91ec2b621b78f6cd9031762067c
net/mlx5e: Fix NULL pointer dereference in ioctl module EEPROM query

The mlx5_query_mcia() function unconditionally dereferences the status
pointer to store the MCIA register status value.
However, mlx5e_get_module_id() passes NULL since it doesn't need the
status value.

Add a NULL check before dereferencing the status pointer to prevent a
NULL pointer dereference.

Fixes: 2e4c44b12f4d ("net/mlx5: Refactor EEPROM query error handling to return status separately")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Link: https://patch.msgid.link/20251225132717.358820-4-mbloch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/port.c