]> git.ipfire.org Git - thirdparty/linux.git/commit
Merge patch series "vfs: properly deny directory leases on filesystems with special...
authorChristian Brauner <brauner@kernel.org>
Mon, 12 Jan 2026 09:54:52 +0000 (10:54 +0100)
committerChristian Brauner <brauner@kernel.org>
Mon, 12 Jan 2026 09:54:52 +0000 (10:54 +0100)
commit7d42f2b1cc3a60a71784967384ddcf29fe3f35ed
treea7f1027bcddc5cf6cdc0902d89866ecb74fbc860
parentcab012375122304a6343c1ed09404e5143b9dc01
parent8a5511eeaa5c4e5c2be6209abe549302b70311b0
Merge patch series "vfs: properly deny directory leases on filesystems with special lease handling"

Jeff Layton <jlayton@kernel.org> says:

Filesystems currently have to set the ->setlease() method explicitly in
order to deny attempts to set a lease or delegation. With the advent of
directory delegations, we now need to set ->setlease on the directory
file_operations for several filesystems to simple_nosetlease() to ensure
this.

This patchset does that. There should be no noticeable change in
behavior, other than fixing the support detection in xfstests, allowing
lease/delegation tests to be properly skipped on these filesystems.

It's probably simplest to merge these all at once via Christian's tree
if he's amenable, but Acks would be welcome. Ideally these would go in
for v6.19.

Long term, I think it would be best to change leases/delegations to be
an opt-in thing, such that leases are always denied by default if the
method isn't set. That's a larger patchset though as we'd need to audit
all of the file_operations that currently have ->setlease() as NULL.

* patches from https://patch.msgid.link/20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org:
  vboxsf: don't allow delegations to be set on directories
  ceph: don't allow delegations to be set on directories
  gfs2: don't allow delegations to be set on directories
  9p: don't allow delegations to be set on directories
  smb/client: properly disallow delegations on directories
  nfs: properly disallow delegation requests on directories

Link: https://patch.msgid.link/20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>