]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix missed step in removal of useless RESULT RTEs in the planner.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Dec 2020 21:16:13 +0000 (16:16 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Dec 2020 21:16:13 +0000 (16:16 -0500)
commit7d43b76f6ed97b3b27f30114636f7b116009ef61
treed2f4450303dc777c575c577f565a0338fdd936a0
parente41a2efbca10438fa0a506d4158edd1a1964aacf
Fix missed step in removal of useless RESULT RTEs in the planner.

Commit 4be058fe9 forgot that the append_rel_list would already be
populated at the time we remove useless result RTEs, and it might contain
PlaceHolderVars that need to be adjusted like the ones in the main parse
tree.  This could lead to "no relation entry for relid N" failures later
on, when the planner tries to do something with an unadjusted PHV.

Per report from Tom Ellis.  Back-patch to v12 where the bug came in.

Discussion: https://postgr.es/m/20201205173056.GF30712@cloudinit-builder
src/backend/optimizer/prep/prepjointree.c
src/test/regress/expected/join.out
src/test/regress/sql/join.sql