]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: qcom: Free sideband sg_table objects
authorXu Rao <raoxu@uniontech.com>
Tue, 16 Jun 2026 11:59:16 +0000 (19:59 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 17 Jun 2026 09:05:18 +0000 (11:05 +0200)
commit7d69804a35103a50852eae41bfe6a2e0061c68fd
treee18587617778470057e1c6982baf2c25693dd31d
parentf7c4968ae3af3e819428da5416c2dfd361473f5c
ALSA: usb-audio: qcom: Free sideband sg_table objects

The Qualcomm USB audio offload driver obtains an endpoint transfer-ring
table by calling xhci_sideband_get_endpoint_buffer(). This getter passes
the endpoint ring to xhci_ring_to_sgtable(), which allocates the outer
struct sg_table with kzalloc_obj(*sgt). The event-ring path is
equivalent: xhci_sideband_get_event_buffer() also returns the result of
xhci_ring_to_sgtable().

Inside xhci_ring_to_sgtable(), sg_alloc_table_from_pages() separately
allocates the scatterlist storage referenced by sgt->sgl. The returned
object therefore has two allocation layers: the outer struct sg_table
and its internal scatterlist storage.

The Qualcomm caller only invokes sg_free_table(sgt). sg_free_table()
releases the scatterlist storage owned by the table, but it does not
free the separately allocated outer struct sg_table. The local sgt
pointer is then discarded, so every successful endpoint or event-ring
query leaks the outer object.

Call kfree(sgt) after sg_free_table(sgt) in both setup paths, after the
required page and DMA addresses have been copied out.

Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: Xu Rao <raoxu@uniontech.com>
Link: https://patch.msgid.link/90B353283AA150C4+20260616115916.1222915-1-raoxu@uniontech.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/qcom/qc_audio_offload.c