]> git.ipfire.org Git - thirdparty/bootstrap.git/commit
`prev()` function fails when non-element nodes are present (#30117)
authorMartijn Cuppens <martijn.cuppens@gmail.com>
Mon, 9 Mar 2020 15:21:04 +0000 (16:21 +0100)
committerGitHub <noreply@github.com>
Mon, 9 Mar 2020 15:21:04 +0000 (17:21 +0200)
commit7d8c7c4ba844f3e70b7cda20a5b813b54e43959d
tree92866d65495021a2c1aa32e2ddf9da19af3bea0f
parent14c4a601fe09cf6f711dffbb9240c4c8abc25767
`prev()` function fails when non-element nodes are present (#30117)

The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.

I've also added an additional test.

I don't think we had this issue in v4, since we relied on jQuery back then.

Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
js/src/dom/selector-engine.js
js/tests/unit/dom/selector-engine.spec.js