]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
V4L: bttv: Prevent NULL pointer dereference in radio_open
authorJean Delvare <khali@linux-fr.org>
Fri, 10 Oct 2008 12:41:38 +0000 (08:41 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 22 Oct 2008 21:13:20 +0000 (14:13 -0700)
commit7da0ca5720bceb79599bc42dde1c0a27107587ee
treea0fde56fcc4fc56fb60a6ce0d2009c05c0349490
parentabcfbcb70bce2a534a7c036abcfa29deec44120b
V4L: bttv: Prevent NULL pointer dereference in radio_open

(cherry picked from commit c37396c19403e249f12626187d51e92c915f2bc9)

Fix the following crash in the bttv driver:

BUG: unable to handle kernel NULL pointer dereference at 000000000000036c
IP: [<ffffffffa037860a>] radio_open+0x3a/0x170 [bttv]

This happens because radio_open assumes that all present bttv devices
have a radio function. If a bttv device without radio and one with
radio are installed on the same system, and the one without radio is
registered first, then radio_open checks for the radio device number
of a bttv device that has no radio function, and this breaks. All we
have to do to fix it is to skip bttv devices without a radio function.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/bt8xx/bttv-driver.c