]> git.ipfire.org Git - thirdparty/linux.git/commit
bpf: Fix invalid prog->stats access when update_effective_progs fails
authorPu Lehui <pulehui@huawei.com>
Sat, 15 Nov 2025 10:23:43 +0000 (10:23 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 18 Nov 2025 06:35:51 +0000 (22:35 -0800)
commit7dc211c1159d991db609bdf4b0fb9033c04adcbc
tree6794ab5d59eb633f5cc001d75c57dfe6bd468d51
parent4722981cca373a338bbcf3a93ecf7144a892b03b
bpf: Fix invalid prog->stats access when update_effective_progs fails

Syzkaller triggers an invalid memory access issue following fault
injection in update_effective_progs. The issue can be described as
follows:

__cgroup_bpf_detach
  update_effective_progs
    compute_effective_progs
      bpf_prog_array_alloc <-- fault inject
  purge_effective_progs
    /* change to dummy_bpf_prog */
    array->items[index] = &dummy_bpf_prog.prog

---softirq start---
__do_softirq
  ...
    __cgroup_bpf_run_filter_skb
      __bpf_prog_run_save_cb
        bpf_prog_run
          stats = this_cpu_ptr(prog->stats)
          /* invalid memory access */
          flags = u64_stats_update_begin_irqsave(&stats->syncp)
---softirq end---

  static_branch_dec(&cgroup_bpf_enabled_key[atype])

The reason is that fault injection caused update_effective_progs to fail
and then changed the original prog into dummy_bpf_prog.prog in
purge_effective_progs. Then a softirq came, and accessing the members of
dummy_bpf_prog.prog in the softirq triggers invalid mem access.

To fix it, skip updating stats when stats is NULL.

Fixes: 492ecee892c2 ("bpf: enable program stats")
Signed-off-by: Pu Lehui <pulehui@huawei.com>
Link: https://lore.kernel.org/r/20251115102343.2200727-1-pulehui@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
include/linux/filter.h
kernel/bpf/syscall.c