]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xhci: dbc: Fix full DbC transfer ring after several reconnects
authorMathias Nyman <mathias.nyman@linux.intel.com>
Tue, 2 Sep 2025 10:53:05 +0000 (13:53 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Sep 2025 14:37:38 +0000 (16:37 +0200)
commit7dc3bd0f7bd5fd11f43a37ec01483994e1b3c07a
tree84508166bb3a3413a7fffd44d651e2a6753bee5f
parentad6a6e97c219f7d9babda511b5e7ea4a88095732
xhci: dbc: Fix full DbC transfer ring after several reconnects

commit a5c98e8b1398534ae1feb6e95e2d3ee5215538ed upstream.

Pending requests will be flushed on disconnect, and the corresponding
TRBs will be turned into No-op TRBs, which are ignored by the xHC
controller once it starts processing the ring.

If the USB debug cable repeatedly disconnects before ring is started
then the ring will eventually be filled with No-op TRBs.
No new transfers can be queued when the ring is full, and driver will
print the following error message:

    "xhci_hcd 0000:00:14.0: failed to queue trbs"

This is a normal case for 'in' transfers where TRBs are always enqueued
in advance, ready to take on incoming data. If no data arrives, and
device is disconnected, then ring dequeue will remain at beginning of
the ring while enqueue points to first free TRB after last cancelled
No-op TRB.
s
Solve this by reinitializing the rings when the debug cable disconnects
and DbC is leaving the configured state.
Clear the whole ring buffer and set enqueue and dequeue to the beginning
of ring, and set cycle bit to its initial state.

Cc: stable@vger.kernel.org
Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20250902105306.877476-3-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-dbgcap.c