]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: adc: ad7124: Remove ability to write filter_low_pass_3db_frequency
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Mon, 17 Mar 2025 11:52:48 +0000 (12:52 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 22 Apr 2025 18:09:58 +0000 (19:09 +0100)
commit7dd17a4e98735b112e25860b3767901799ea0d61
treee291214565fee3214a926c205492062263f591f2
parent8712e4986e7ce42a14c762c4c350f290989986a5
iio: adc: ad7124: Remove ability to write filter_low_pass_3db_frequency

There are several issues with the function that implements writing to
the filter_low_pass_3db_frequency property:

 - The sinc3 factor should be 0.272 not 0.262 (this is fixed for the
   reading side in the previous patch).
 - For freq > 1 the if condition is always true so the sinc4 filter is
   hardly ever chosen.
 - In the nearly always taken if branch the filter is set to sinc3, but
   the frequency is set for sinc4. (And vice versa in the else branch.)

This is broken enough to justify the claim that there isn't any serious
user. Also it it counter-intuitive that setting the 3db frequency
modifies the sample frequency and the filter type.

So drop the ability to write that property.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Link: https://patch.msgid.link/20250317115247.3735016-7-u.kleine-koenig@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7124.c