]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Adapt to RegGetValue brokenness in Windows 7
authorSelva Nair <selva.nair@gmail.com>
Wed, 21 Feb 2018 05:38:30 +0000 (00:38 -0500)
committerGert Doering <gert@greenie.muc.de>
Wed, 21 Feb 2018 18:07:41 +0000 (19:07 +0100)
commit7de0ee4f6f6f44fab48717e4cc2073ff4e8580f6
tree6d96d6c7229e2ea340177f4ad01f3273e6fe680d
parent028b501734b4a57dc53edb8b11a4b370f5b99e38
Adapt to RegGetValue brokenness in Windows 7

- RegGetValue with flags = RRF_RT_REG_SZ|RRF_RT_REG_EXPAND_SZ
  fails in Windows 7 with an "invalid parameter" error.
  Fix by using RRF_RT_REG_SZ alone.

Note: This is not a regression as in no released version did the
service support expandable strings (ones with embedded %FOO%) in
the registry. However, the GUI does expand such strings. The two
can be made consistent by explicitly expanding the strings -- that
is left for a future patch.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1519191510-3826-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16513.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpnserv/common.c