]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
workqueue: Don't call cpumask_test_cpu() with -1 CPU in wq_update_node_max_active()
authorTejun Heo <tj@kernel.org>
Wed, 31 Jan 2024 04:55:55 +0000 (18:55 -1000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:16 +0000 (18:19 -0400)
commit7df62b8cca38aa452b508b477b16544cba615084
treee948c60aa3cf467eacad1b397566303ef8f62f63
parent5a70baec2294e8a7d0fcc4558741c23e752dad5c
workqueue: Don't call cpumask_test_cpu() with -1 CPU in wq_update_node_max_active()

[ Upstream commit 15930da42f8981dc42c19038042947b475b19f47 ]

For wq_update_node_max_active(), @off_cpu of -1 indicates that no CPU is
going down. The function was incorrectly calling cpumask_test_cpu() with -1
CPU leading to oopses like the following on some archs:

  Unable to handle kernel paging request at virtual address ffff0002100296e0
  ..
  pc : wq_update_node_max_active+0x50/0x1fc
  lr : wq_update_node_max_active+0x1f0/0x1fc
  ...
  Call trace:
    wq_update_node_max_active+0x50/0x1fc
    apply_wqattrs_commit+0xf0/0x114
    apply_workqueue_attrs_locked+0x58/0xa0
    alloc_workqueue+0x5ac/0x774
    workqueue_init_early+0x460/0x540
    start_kernel+0x258/0x684
    __primary_switched+0xb8/0xc0
  Code: 9100a273 35000d01 53067f00 d0016dc1 (f8607a60)
  ---[ end trace 0000000000000000 ]---
  Kernel panic - not syncing: Attempted to kill the idle task!
  ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]---

Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: http://lkml.kernel.org/r/91eacde0-df99-4d5c-a980-91046f66e612@samsung.com
Fixes: 5797b1c18919 ("workqueue: Implement system-wide nr_active enforcement for unbound workqueues")
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/workqueue.c