]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 11 Apr 2022 11:10:33 +0000 (11:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:53:48 +0000 (16:53 +0200)
commit7e0f7d9c722eb128d0dcaa1c47e1b2f8e79181c5
tree4fe06e1395fe5417ce7d096bc748ba1b2914a342
parent160c9561d65cfd2365fef9d6f6aa2afe28353e39
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout

[ Upstream commit 8b1ea69a63eb62f97cef63e6d816b64ed84e8760 ]

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 5720ec0a6d26 ("spi: spi-ti-qspi: Add DMA support for QSPI mmap read")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411111034.24447-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-ti-qspi.c